linux-kernel - Re: [PATCH] net: usb: Fix typo in code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yr6R/wsl+HlOwOEm@kroah.com>
Date:   Fri, 1 Jul 2022 08:19:43 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Li kunyu <kunyu@...china.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: Fix typo in code

On Fri, Jul 01, 2022 at 10:07:51AM +0800, Li kunyu wrote:
> hasdata does not need to be initialized to zero. It will be assigned a
> value in the following judgment conditions.
> Remove the repeated ';' from code.

That is a lot of different things all in the same commit.  Please break
this up into one-change-per-commit like is required.

You also do something in here that you do not document :(

thanks,

greg k-h