[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1bc0670f-081e-c2b7-940c-9ec1f3940408@linaro.org>
Date: Fri, 1 Jul 2022 08:21:03 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Kumar Gala <galak@...eaurora.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH v5 1/3] dt-bindings: arm: qcom: document qcom,msm-id and
qcom,board-id
On 01/07/2022 00:35, Rob Herring wrote:
(...)
>> ...
>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>> new file mode 100644
>> index 000000000000..635d4ebba3fe
>> --- /dev/null
>> +++ b/include/dt-bindings/arm/qcom,ids.h
>> @@ -0,0 +1,146 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>
> Sigh... Pretty sure relicensing this is okay.
Indeed, I can relicense it.
>
>> +/*
>> + * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2022 Linaro Ltd
>> + * Author: Krzysztof Kozlowski <krzk@...nel.org> based on previous work of Kumar Gala.
>> + */
>> +#ifndef _DT_BINDINGS_ARM_QCOM_IDS_H
>> +#define _DT_BINDINGS_ARM_QCOM_IDS_H
>> +
(...)
>> +#define QCOM_ID_IPQ6005 453
>> +#define QCOM_ID_QRB5165 455
>> +#define QCOM_ID_SM8450 457
>> +#define QCOM_ID_SM7225 459
>> +#define QCOM_ID_SA8540P 460
>> +#define QCOM_ID_SM8450_2 480
>> +#define QCOM_ID_SM8450_3 482
>
>> +#define QCOM_ID_SC7280 487
>
> Not what I'd call an old SoC and not in the allowed list. Neither are a
> bunch of others.
Correct, but these are here for other reason - patch 2. These are not
needed for the qcom,board-id property but they will be used by
drivers/soc/qcom/socinfo driver. The values are stored in shared memory
(smem) and accessible/used by Linux, bootloader and firmware. We need to
be sure each define is consistent across different software. Therefore I
consider them values matching bindings.
Best regards,
Krzysztof
Powered by blists - more mailing lists