linux-kernel - Re: [PATCH v4 26/34] tools/testing/nvdimm: Convert to printbuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b299ebe2-88e5-c2bd-bad0-bef62d4acdfe@linux.ibm.com>
Date:   Fri, 1 Jul 2022 12:02:51 +0530
From:   Shivaprasad G Bhat <sbhat@...ux.ibm.com>
To:     Santosh Sivaraj <santosh@...six.org>,
        Dan Williams <dan.j.williams@...el.com>
Cc:     Kent Overstreet <kent.overstreet@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>, enozhatsky@...omium.org,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        willy@...radead.org, Dave Hansen <dave.hansen@...ux.intel.com>,
        Linux NVDIMM <nvdimm@...ts.linux.dev>,
        Vaibhav Jain <vaibhav@...ux.ibm.com>
Subject: Re: [PATCH v4 26/34] tools/testing/nvdimm: Convert to printbuf

On 6/25/22 05:12, Santosh Sivaraj wrote:
> I don't have setup to test this now. Adding Shiva and Vaibhav who could 
> probably help. Thanks, Santosh On Sat, 25 Jun, 2022, 1:03 am Dan 
> Williams, <dan.j.williams@...el.com> wrote: [ add Santosh ] Kent 
> Overstreet wrote: ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍
> ZjQcmQRYFpfptBannerStart
> This Message Is From an External Sender
> This message came from outside your organization.
> ZjQcmQRYFpfptBannerEnd
> I don't have setup to test this now. Adding Shiva and Vaibhav who could 
> probably help.
> 
> Thanks,
> Santosh
> 
> On Sat, 25 Jun, 2022, 1:03 am Dan Williams, <dan.j.williams@...el.com 
> <mailto:dan.j.williams@...el.com>> wrote:
> 
>     [ add Santosh ]
> 
>     Kent Overstreet wrote:
>      > This converts from seq_buf to printbuf. Here we're using printbuf
>     with
>      > an external buffer, meaning it's a direct conversion.
>      >
>      > Signed-off-by: Kent Overstreet <kent.overstreet@...il.com
>     <mailto:kent.overstreet@...il.com>>
>      > Cc: Dan Williams <dan.j.williams@...el.com
>     <mailto:dan.j.williams@...el.com>>
>      > Cc: Dave Hansen <dave.hansen@...ux.intel.com
>     <mailto:dave.hansen@...ux.intel.com>>
>      > Cc: nvdimm@...ts.linux.dev <mailto:nvdimm@...ts.linux.dev>
> 
>     Acked-by: Dan Williams <dan.j.williams@...el.com
>     <mailto:dan.j.williams@...el.com>>
> 

The ndtest build requires [1] as the build is currently broken from 
nd_namespace_blk/blk_region infrastructure removal.

Dan, Could you review [1] and see if it can be included as well ?

With [1], the this patch is tested, and works fine.

Tested-By: Shivaprasad G Bhat <sbhat@...ux.ibm.com>

References:
[1] 
https://patchwork.kernel.org/project/linux-nvdimm/patch/165025395730.2821159.14794984437851867426.stgit@lep8c.aus.stglabs.ibm.com/


>     This probably also wants a Tested-by from Santosh, but it looks ok
>     to me.
>