linux-kernel - Re: [Patch net-next v14 10/13] net: dsa: microchip: lan937x: add phylink_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yr6rWE38HH3dSQHV@shell.armlinux.org.uk>
Date:   Fri, 1 Jul 2022 09:07:52 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Arun.Ramadoss@...rochip.com
Cc:     andrew@...n.ch, linux-kernel@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, vivien.didelot@...il.com,
        ast@...nel.org, bpf@...r.kernel.org, olteanv@...il.com,
        devicetree@...r.kernel.org, robh+dt@...nel.org, andrii@...nel.org,
        songliubraving@...com, f.fainelli@...il.com, daniel@...earbox.net,
        john.fastabend@...il.com, kuba@...nel.org, edumazet@...gle.com,
        pabeni@...hat.com, kpsingh@...nel.org, netdev@...r.kernel.org,
        Woojung.Huh@...rochip.com, krzysztof.kozlowski+dt@...aro.org,
        yhs@...com, davem@...emloft.net, kafai@...com
Subject: Re: [Patch net-next v14 10/13] net: dsa: microchip: lan937x: add
 phylink_get_caps support

On Fri, Jul 01, 2022 at 05:51:33AM +0000, Arun.Ramadoss@...rochip.com wrote:
> > > +void lan937x_phylink_get_caps(struct ksz_device *dev, int port,
> > > +                           struct phylink_config *config)
> > > +{
> > > +     config->mac_capabilities = MAC_100FD;
> > > +
> > > +     if (dev->info->supports_rgmii[port]) {
> > > +             /* MII/RMII/RGMII ports */
> > > +             config->mac_capabilities |= MAC_ASYM_PAUSE |
> > > MAC_SYM_PAUSE |
> > > +                                         MAC_100HD | MAC_10 |
> > > MAC_1000FD;
> > 
> > And SGMII too? (Which seems to be a given because from your list in
> > the
> > series cover message, SGMII ports also support RGMII).
> 
> No, SGMII port does not support the RGMII. I have mentioned in the
> cover message that LAN9373 has 2 RGMII and 1 SGMII port. No other part
> number has SGMII port.

So when using SGMII, there's no way for pause frames to be supported?
It seems a bit weird that the pause frame capability is dependent on
the interface type, as pause frames are just the same as normal
ethernet frames, except they're ggenerally enerated and/or interpreted
by the MAC.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!