linux-kernel - Re: [PATCH] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings.

Open Source and information security mailing list archives

Message-ID: <3ef4a858-9534-0b4f-744b-b254bb7555f2@microchip.com>
Date:   Fri, 1 Jul 2022 08:32:36 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <Kavyasree.Kotagiri@...rochip.com>, <arnd@...db.de>,
        <alexandre.belloni@...tlin.com>,
        <krzysztof.kozlowski+dt@...aro.org>, <soc@...nel.org>,
        <robh+dt@...nel.org>, <Nicolas.Ferre@...rochip.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl
 settings.

On 27.06.2022 12:12, Kavyasree Kotagiri wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On pcb8291, Flexcom3 usart has only tx and rx pins.
> Cleaningup usart3 pinctrl settings.
> 
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
> ---
>  arch/arm/boot/dts/lan966x-pcb8291.dts | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 3c7e3a7d6f14..5dc8ed4cee9a 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -19,19 +19,13 @@
>  };
> 
>  &gpio {
> -       fc_shrd7_pins: fc_shrd7-pins {
> -               pins = "GPIO_49";
> -               function = "fc_shrd7";
> -       };
> -
> -       fc_shrd8_pins: fc_shrd8-pins {
> -               pins = "GPIO_54";
> -               function = "fc_shrd8";
> +       fc3_b_rxd_pins: fc3-b-rxd-pins {
> +               pins = "GPIO_52";
> +               function = "fc3_b";
>         };
> 
> -       fc3_b_pins: fcb3-spi-pins {
> -               /* SCK, RXD, TXD */
> -               pins = "GPIO_51", "GPIO_52", "GPIO_53";
> +       fc3_b_txd_pins: fc3-b-txd-pins {
> +               pins = "GPIO_53";

Could we keep both pins under the same node? As in case of can0_b_pins,
something like:

	fc3_b_pins: fc3-b-pins {
		pins = "GPIO_52", "GPIO_53";
		function = "fc3_b";
	};

Thank you,
Claudiu Beznea

>                 function = "fc3_b";
>         };
> 
> @@ -53,7 +47,7 @@
>         status = "okay";
> 
>         usart3: serial@200 {
> -               pinctrl-0 = <&fc3_b_pins>, <&fc_shrd7_pins>, <&fc_shrd8_pins>;
> +               pinctrl-0 = <&fc3_b_rxd_pins>, <&fc3_b_txd_pins>;
>                 pinctrl-names = "default";
>                 status = "okay";
>         };
> --
> 2.17.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives