lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jul 2022 09:49:46 +0800 From: Lin Feng <linf@...gsu.com> To: Tejun Heo <tj@...nel.org> Cc: lizefan.x@...edance.com, hannes@...xchg.org, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] cgroup-v1: use find granularity format identifiers to make /proc/cgroups show pretty Hi Tejun, On 7/1/22 09:09, Tejun Heo wrote: > On Thu, Jun 30, 2022 at 04:25:39PM +0800, Lin Feng wrote: >> The listing subsys info is unaligned with the header columns and we can >> make the output more intuitive to read by specifying "left alignment" >> and "fixed length" format styles for seq_printf. > This has been proposed before but the file is useful only in cgroup1 > which is in maintenance mode and the format has been like that since > forever. Given that there's some chance that it can break dumb > parsers, the choice has been to leave it alone. It's such a dumb file > format to begin with and just leaving it to wither and die seems to be > the right direction. Thanks for your explanation and sorry that I missed we have such a consensus before. I had considered that if this change would break the parsers, but it's likely that it won't else the parser is really a broken one and needs some improvements. On the other hand, cgroup-v1 still has many old users and kernel still has to maintain it for some time for back compatible reason, so I think this tiny fix should not be a bad idea. Thanks, linfeng
Powered by blists - more mailing lists