linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9be8f4c-ec35-1457-742b-fdef55640fe6@linaro.org>
Date:   Fri, 1 Jul 2022 10:27:09 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Nishanth Menon <nm@...com>,
        Angelo Compagnucci <angelo.compagnucci@...il.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Jonathan Cameron <jic23@...nel.org>
Cc:     Florian Eckert <fe@....tdt.de>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and
 adc10c family

On 01/07/2022 08:38, Krzysztof Kozlowski wrote:
> On 01/07/2022 06:29, Nishanth Menon wrote:
>> The adcxx4s communicates with a host processor via an SPI/Microwire Bus
>> interface. The device family responds with 12bit data, of which the LSB
>> bits are 0 for the lower resolution devices. I have been able to test
>> adc102s051, hence adding just the missing ones in that family.
>>
>> Lets reuse the binding to support the family of devices with name
>> ADC<bb><c>S<sss>, where
>> * bb is the resolution in number of bits (8, 10, 12)
>> * c is the number of channels (1, 2, 4, 8)
>> * sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
>>   and 101 for 1 MSPS)
>>
>> Complete datasheets are available at TI's website here:
>>   https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf
>>
>> Handling of 8, 10 and 12 bits converters are the same, the
>> unavailable bits are 0 in LSB :)
>>
>> Inspired-by: drivers/hwmon/adcxx.c
>>
>> Signed-off-by: Nishanth Menon <nm@...com>
>> ---
>>
>> Checkpatch does complain with Inspired-by: insisting it to be an email
>> address.. but I was really inspired by the hwmon driver.. Don't know
>> what else to say here.. we could probably drop it?
> 
> Drop it or convert to just test.

This should be:

Drop it or convert to just text sentence.

Best regards,
Krzysztof