linux-kernel - Re: [PATCH v1 1/2] gpio: adnp: use simple i2c probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=McB4XXpGK4=PwNX8n60r-2yC=hbN2fPjQTZ1SUh8dd9yA@mail.gmail.com>
Date:   Fri, 1 Jul 2022 11:36:41 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/2] gpio: adnp: use simple i2c probe function

On Tue, Jun 28, 2022 at 9:59 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> The i2c probe functions here don't use the id information provided in
> their second argument, so the single-parameter i2c probe function
> ("probe_new") can be used instead.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpio-adnp.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c
> index cc349d4e4973..075782831044 100644
> --- a/drivers/gpio/gpio-adnp.c
> +++ b/drivers/gpio/gpio-adnp.c
> @@ -485,8 +485,7 @@ static int adnp_gpio_setup(struct adnp *adnp, unsigned int num_gpios,
>         return 0;
>  }
>
> -static int adnp_i2c_probe(struct i2c_client *client,
> -                                   const struct i2c_device_id *id)
> +static int adnp_i2c_probe(struct i2c_client *client)
>  {
>         struct device_node *np = client->dev.of_node;
>         struct adnp *adnp;
> @@ -535,7 +534,7 @@ static struct i2c_driver adnp_i2c_driver = {
>                 .name = "gpio-adnp",
>                 .of_match_table = adnp_of_match,
>         },
> -       .probe = adnp_i2c_probe,
> +       .probe_new = adnp_i2c_probe,
>         .id_table = adnp_i2c_id,
>  };
>  module_i2c_driver(adnp_i2c_driver);
> --
> 2.35.1
>

Applied, thanks!

Bart