linux-kernel - Re: [PATCH v3] dmaengine: idxd: force wq context cleanup on device disable path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yr7dt1TdlVLNL30D@matsya>
Date:   Fri, 1 Jul 2022 17:12:47 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Fenghua Yu <fenghua.yu@...el.com>
Cc:     Dave Jiang <dave.jiang@...el.com>, Tony Zhu <tony.zhu@...el.com>,
        dmaengine@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] dmaengine: idxd: force wq context cleanup on device
 disable path

On 28-06-22, 16:00, Fenghua Yu wrote:
> From: Dave Jiang <dave.jiang@...el.com>
> 
> Testing shown that when a wq mode is setup to be dedicated and then torn
> down and reconfigured to shared, the wq configured end up being dedicated
> anyays. The root cause is when idxd_device_wqs_clear_state() gets called
> during idxd_driver removal, idxd_wq_disable_cleanup() does not get called
> vs when the wq driver is removed first. The check of wq state being
> "enabled" causes the cleanup to be bypassed. However, idxd_driver->remove()
> releases all wq drivers. So the wqs goes to "disabled" state and will never
> be "enabled". By that point, the driver has no idea if the wq was
> previously configured or clean. So force call idxd_wq_disable_cleanup() on
> all wqs always to make sure everything gets cleaned up.

Applied, thanks

-- 
~Vinod