linux-kernel - Re: [PATCH] scsi: bfa: use strscpy to replace strlcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1338d1aed2e55c3107363a6b7e521d75f877db2f.camel@linux.ibm.com>
Date:   Fri, 01 Jul 2022 07:43:30 -0400
From:   James Bottomley <jejb@...ux.ibm.com>
To:     XueBing Chen <chenxuebing@...i.cn>, martin.petersen@...cle.com
Cc:     anil.gurumurthy@...gic.com, sudarsana.kalluru@...gic.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: bfa: use strscpy to replace strlcpy

On Fri, 2022-07-01 at 19:16 +0800, XueBing Chen wrote:
> The strlcpy should not be used

That's not true.

>  because it doesn't limit the source length. Preferred is strscpy.

And that's not the reason why strscpy is often a marginally better
choice.  In the case of what you change in bfa, none of the reasons why
strscpy might be marginally better actually apply.

James