linux-kernel - Re: [PATCH] KVM: x86/mmu: Return true/false from bool function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALMp9eSFvTFn5Uogyu2XJbu6gcNL89R7OqbeF1yop650PUhYJw@mail.gmail.com>
Date:   Fri, 1 Jul 2022 06:08:45 -0700
From:   Jim Mattson <jmattson@...gle.com>
To:     Bo Liu <liubo03@...pur.com>
Cc:     seanjc@...gle.com, pbonzini@...hat.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        x86@...nel.org, hpa@...or.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: Return true/false from bool function

On Thu, Jun 30, 2022 at 10:50 PM Bo Liu <liubo03@...pur.com> wrote:
>
> Return boolean values ("true" or "false") instead of integer values
> from bool function.
>
> Signed-off-by: Bo Liu <liubo03@...pur.com>
> ---
>  arch/x86/kvm/mmu/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index bfb50262fd37..572e0c487376 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -1024,7 +1024,7 @@ static bool rmap_can_add(struct kvm_vcpu *vcpu)
>         struct kvm_mmu_memory_cache *mc;
>
>         mc = &vcpu->arch.mmu_pte_list_desc_cache;
> -       return kvm_mmu_memory_cache_nr_free_objects(mc);
> +       return !!kvm_mmu_memory_cache_nr_free_objects(mc);

This is entirely unnecessary, since conversion of any scalar type to
bool already converts 0 to false and non-zero to true.

>  }
>
>  static void rmap_remove(struct kvm *kvm, u64 *spte)
> --
> 2.27.0
>