linux-kernel - Re: [PATCH v2] stack: Declare {randomize_,}kstack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165672376092.2486882.1451446093485208376.b4-ty@chromium.org>
Date:   Fri,  1 Jul 2022 18:02:43 -0700
From:   Kees Cook <keescook@...omium.org>
To:     gongruiqi1@...wei.com, elver@...gle.com
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org, christophe.leroy@...roup.eu,
        xiujianfeng@...wei.com, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings

On Wed, 29 Jun 2022 14:04:23 +0800, GONG, Ruiqi wrote:
> Fix the following Sparse warnings that got noticed when the PPC-dev
> patchwork was checking another patch (see the link below):
> 
> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
> 
> Which in fact are triggered on all architectures that have
> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
> etc).
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
      https://git.kernel.org/kees/c/375561bd6195

-- 
Kees Cook