linux-kernel - Re: [PATCH v3 1/9] drm: selftest: convert drm_damage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff375c95-96e9-6bcf-66ea-f70a44d0a5d1@redhat.com>
Date:   Sat, 2 Jul 2022 13:32:52 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Maíra Canal <maira.canal@....br>,
        Isabella Basso <isabbasso@...eup.net>, magalilemes00@...il.com,
        tales.aparecida@...il.com, mwen@...lia.com, andrealmeid@...eup.net,
        siqueirajordao@...eup.net, Trevor Woerner <twoerner@...il.com>,
        leandro.ribeiro@...labora.com, n@...aprado.net,
        Daniel Vetter <daniel@...ll.ch>,
        Shuah Khan <skhan@...uxfoundation.org>,
        David Airlie <airlied@...ux.ie>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        michal.winiarski@...el.com,
        José Expósito <jose.exposito89@...il.com>,
        David Gow <davidgow@...gle.com>,
        Daniel Latypov <dlatypov@...gle.com>, brendanhiggins@...gle.com
Cc:     kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Arthur Grillo <arthur.grillo@....br>
Subject: Re: [PATCH v3 1/9] drm: selftest: convert drm_damage_helper selftest
 to KUnit

Hello Maíra,

Thanks a lot for your patch.

On 6/30/22 02:46, Maíra Canal wrote:
> Considering the current adoption of the KUnit framework, convert the
> DRM damage helper selftest to the KUnit API.
> 
> Acked-by: Daniel Latypov <dlatypov@...gle.com>
> Tested-by: David Gow <davidgow@...gle.com>
> Co-developed-by: Arthur Grillo <arthur.grillo@....br>
> Signed-off-by: Arthur Grillo <arthur.grillo@....br>
> Signed-off-by: Maíra Canal <maira.canal@....br>

I believe the order of the tags should be chronological. That is, Daniel and
David tags should be after your Co-developed-by and Signed-off-by tags.

[...]

> +++ b/drivers/gpu/drm/tests/drm_damage_helper_test.c
> @@ -0,0 +1,634 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Test case for drm_damage_helper functions
> + */
> +
> +#include <kunit/test.h>

Please add a blank line here to separate non-DRM headers include from DRM headers.

> +#include <drm/drm_damage_helper.h>
> +#include <drm/drm_framebuffer.h>
> +#include <drm/drm_plane.h>
> +#include <drm/drm_drv.h>
> +

I haven't looked at the KUnits tests in detail since Daniel and David already
reviewed them. But from a quick glance, the tests look good to me as well.

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat