lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 Jul 2022 10:16:41 -0500 From: Samuel Holland <samuel@...lland.org> To: Aidan MacDonald <aidanmacdonald.0x0@...il.com>, wens@...e.org Cc: linus.walleij@...aro.org, brgl@...ev.pl, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, jic23@...nel.org, sre@...nel.org, lee.jones@...aro.org, lgirdwood@...il.com, broonie@...nel.org, lars@...afoo.de, quic_gurus@...cinc.com, sebastian.reichel@...labora.com, andy.shevchenko@...il.com, michael@...le.cc, rdunlap@...radead.org, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org, linux-pm@...r.kernel.org Subject: Re: [PATCH v4 04/15] dt-bindings: gpio: Add AXP192 GPIO bindings On 6/29/22 9:30 AM, Aidan MacDonald wrote: > The AXP192 PMIC is different enough from the PMICs supported by > the AXP20x GPIO driver to warrant a separate driver. The AXP192 > driver also supports interrupts and pinconf settings. > > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com> > --- > .../bindings/gpio/x-powers,axp192-gpio.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml b/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > new file mode 100644 > index 000000000000..ceb94aa2bc97 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > [...] > + > +required: > + - compatible > + - "#gpio-cells" > + - gpio-controller > + - gpio-ranges By requiring the gpio-ranges property, you will not be able to convert the existing driver, as existing devicetrees do not have it. If you instead call pinctrl_add_gpio_range() from the driver, you can maintain compatibility with the existing binding. Regards, Samuel
Powered by blists - more mailing lists