[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YsCdSkzSbVz9gnci@smile.fi.intel.com>
Date: Sat, 2 Jul 2022 22:32:26 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: agk@...hat.com, snitzer@...nel.org, dm-devel@...hat.com,
vneethv@...ux.ibm.com, oberpar@...ux.ibm.com, hca@...ux.ibm.com,
gor@...ux.ibm.com, agordeev@...ux.ibm.com,
borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
almaz.alexandrovich@...agon-software.com, yury.norov@...il.com,
linux@...musvillemoes.dk, linux-s390@...r.kernel.org,
ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/4] s390/cio: Rename bitmap_size() as idset_bitmap_size()
On Sat, Jul 02, 2022 at 09:24:24PM +0200, Christophe JAILLET wrote:
> Le 02/07/2022 à 20:54, Andy Shevchenko a écrit :
> > On Sat, Jul 02, 2022 at 08:29:09PM +0200, Christophe JAILLET wrote:
...
> > > - memset(set->bitmap, 0, bitmap_size(num_ssid, num_id));
> > > + memset(set->bitmap, 0, idset_bitmap_size(num_ssid, num_id));
> >
> > Why not to use bitmap_zero()?
...
> > > - memset(set->bitmap, 0xff, bitmap_size(set->num_ssid, set->num_id));
> > > + memset(set->bitmap, 0xff, idset_bitmap_size(set->num_ssid, set->num_id));
> >
> > Why not to use bitmap_fill() ?
> For this initial step, I wanted to keep changes as minimal as possible (i.e
> just function renaming)
>
> In fact, I plan to send a follow-up patch on this file.
> This would remove the newly renamed idset_bitmap_size() function, use the
> bitmap API directly (as you pointed-out) with
> "set->num_ssid * set->num_id" as size.
>
> It is already done this way in idset_is_empty(), so it would be more
> consistent.
>
> If the serie needs a v2 (or if required), I can add an additional 5th patch
> for it. Otherwise it will send separatly later.
If you use bitmap APIs as I suggested above as the first patch, the rest will
have less unneeded churn, no?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists