[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAAhV-H60k06-JO1jEwbOkW2O+QUaF7vCbGXO0EPjJ81kdU14FQ@mail.gmail.com>
Date: Sat, 2 Jul 2022 11:34:59 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: WANG Xuerui <kernel@...0n.name>, Guo Ren <guoren@...nel.org>,
loongarch@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] LoongArch: Fix build errors
Hi, Guenter,
On Fri, Jul 1, 2022 at 10:49 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> A number of build errors is seen when trying to build loongarch:allnoconfig
> or loongarch:tinyconfig. This patch series tries to fix the observed
> errors.
Thank you very much for your patches. From my point of view, the first
patch is good, but we usually include <linux/xxx> before <asm/yyy>;
the second patch is not so good, and I think the correct way is modify
the cflags for vdso [1]; and the third patch can be dropped at this
time, until our kernel is bootable.
[1] https://lore.kernel.org/loongarch/20220623044715.2072428-1-chenhuacai@loongson.cn/T/#u
Huacai
>
> ----------------------------------------------------------------
> Guenter Roeck (3):
> LoongArch: page.h: Add missing include file
> LoongArch: Do not include file from toolchain
> LoongArch: Always select EFI
>
> arch/loongarch/Kconfig | 6 ++----
> arch/loongarch/include/asm/loongarch.h | 23 +++++++++++------------
> arch/loongarch/include/asm/page.h | 1 +
> 3 files changed, 14 insertions(+), 16 deletions(-)
Powered by blists - more mailing lists