linux-kernel - Re: [PATCH v3 0/6] Staging: rtl8192e: rtllib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eeafc6b3-1a47-4729-a4b0-1c841586f6fd@gmail.com>
Date:   Sat, 2 Jul 2022 08:17:58 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Felix Schlepper <f3sch.git@...look.com>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        wjsota@...il.com
Subject: Re: [PATCH v3 0/6] Staging: rtl8192e: rtllib_wx

On 7/1/22 11:24, Felix Schlepper wrote:
> This series addresses some issues raised by chechpatch.pl
> and some very minor refactoring.
> 
> v2:
>      - The first version, only addressed coding style issues.
>        Now, I additionally refactored rtllib_modes and its uses, since
>        there is no need to use string formatting.
>      - Logically separated one assignement into two. So we dont have
>        'fixed' = 'disabled', which was silly.
> 
> v3:
>      - Fixed a checkpatch.pl warning, which was introduced with patch 1/6.
> 
> Felix Schlepper (6):
>    Staging: rtl8192e: Refactored rtllib_modes
>    Staging: rtl8192e: Avoid multiple assignments
>    Staging: rtl8192e: Remove unnecessary parentheses
>    Staging: rtl8192e: Added braces around else
>    Staging: rtl8192e: Remove unnecessary blank line
>    Staging: rtl8192e: Added spaces around '+'
> 
>   drivers/staging/rtl8192e/rtllib_wx.c | 37 +++++++++++-----------------
>   1 file changed, 15 insertions(+), 22 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>

Sorry for sending one email for each patch. Next time I will just send 
one mail for one patch series.


When compiling I saw that the driver is divided into more modules. So 
the r8192e_pci.ko is not touched by this patch series.

kernel@...rix-ESPRIMO-P710:~/Documents/git/kernels/staging$ make -C . 
M=drivers/staging/rtl8192e
make: Entering directory '/home/kernel/Documents/git/kernels/staging'
   CC [M]  drivers/staging/rtl8192e/rtllib_wx.o
   LD [M]  drivers/staging/rtl8192e/rtllib.o
   MODPOST drivers/staging/rtl8192e/Module.symvers
   CC [M]  drivers/staging/rtl8192e/rtllib.mod.o
   LD [M]  drivers/staging/rtl8192e/rtllib.ko
make: Leaving directory '/home/kernel/Documents/git/kernels/staging'

kernel@...rix-ESPRIMO-P710:~/Documents/git/kernels/staging$ sudo insmod 
drivers/staging/rtl8192e/rtllib.ko
kernel@...rix-ESPRIMO-P710:~/Documents/git/kernels/staging$ sudo insmod 
drivers/staging/rtl8192e/rtl8192e/r8192e_pci.ko