linux-kernel - Re: [PATCH] staging: r8188eu: make ffaddr2pipehdl() static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3e6cf6e-9185-d9ea-9e2e-15c616e7c76c@gmail.com>
Date:   Sat, 2 Jul 2022 09:14:31 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Michael Straube <straube.linux@...il.com>,
        gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: make ffaddr2pipehdl() static

On 7/2/22 08:46, Michael Straube wrote:
> The function ffaddr2pipehdl() is only used in usb_ops_linux.c.
> Make it static.
> 
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>   drivers/staging/r8188eu/include/usb_ops_linux.h | 2 --
>   drivers/staging/r8188eu/os_dep/usb_ops_linux.c  | 2 +-
>   2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h
> index 641f059ffaf7..966688eedf66 100644
> --- a/drivers/staging/r8188eu/include/usb_ops_linux.h
> +++ b/drivers/staging/r8188eu/include/usb_ops_linux.h
> @@ -26,6 +26,4 @@
>   #define usb_read_interrupt_complete(purb, regs)		\
>   	usb_read_interrupt_complete(purb)
>   
> -unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr);
> -
>   #endif
> diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> index 0269e602b217..220e592b757c 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
> @@ -7,7 +7,7 @@
>   #include "../include/usb_ops_linux.h"
>   #include "../include/rtl8188e_recv.h"
>   
> -unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)
> +static unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)
>   {
>   	unsigned int pipe = 0, ep_num = 0;
>   	struct usb_device *pusbd = pdvobj->pusbdev;

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> # Edimax N150