linux-kernel - Re: [PATCH V2 7/9] interconnect: imx: set of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 3 Jul 2022 16:43:01 +0800
From:   "Peng Fan (OSS)" <peng.fan@....nxp.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Lucas Stach <l.stach@...gutronix.de>
Cc:     djakov@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        festevam@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, abel.vesa@....com,
        abailon@...libre.com, marex@...x.de, paul.elder@...asonboard.com,
        Markus.Niebel@...tq-group.com, aford173@...il.com,
        kernel@...gutronix.de, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-imx@....com,
        abelvesa@...nel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V2 7/9] interconnect: imx: set of_node for interconnect
 provider



在 2022/6/30 1:32, Laurent Pinchart 写道:
> On Wed, Jun 29, 2022 at 05:08:58PM +0200, Lucas Stach wrote:
>> Am Donnerstag, dem 16.06.2022 um 15:33 +0800 schrieb Peng Fan (OSS):
>>> From: Peng Fan <peng.fan@....com>
>>>
>>> The provider device is created using platform_device_register_data in
>>> imx-bus driver, which not has of_node. With of_node set, it will be
>>> easy to support QoS settings.
>>>
>> That's a bit dangerous, as sharing a of_node between two devices can
>> lead to some reference counting issues IIRC, but then I also don't see
>> a good way to do this any differently.
>>
>> Regards,
>> Lucas
>>
>>> Signed-off-by: Peng Fan <peng.fan@....com>
>>> ---
>>>   drivers/interconnect/imx/imx.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/interconnect/imx/imx.c b/drivers/interconnect/imx/imx.c
>>> index 1f16eedea21c..78557fe6da2c 100644
>>> --- a/drivers/interconnect/imx/imx.c
>>> +++ b/drivers/interconnect/imx/imx.c
>>> @@ -264,6 +264,7 @@ int imx_icc_register(struct platform_device *pdev,
>>>   	provider->xlate = of_icc_xlate_onecell;
>>>   	provider->data = data;
>>>   	provider->dev = dev->parent;
>>> +	provider->dev->of_node = dev->parent->of_node;
> Due to the previous line, provider->dev is equal to dev->parent, so
> doesn't this essentially do
>
> 	dev->parent->of_node = dev->parent->of_node;
>
> which is a no-op ?

hmm. Indeed, I just not able to recall the issue I met before. I'll drop 
this patch in V3.

Thanks,
Peng.

>
>>>   	platform_set_drvdata(pdev, imx_provider);
>>>   
>>>   	ret = icc_provider_add(provider);