[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YsERO3OpZSJuC4hW@casper.infradead.org>
Date: Sun, 3 Jul 2022 04:47:07 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc: akpm@...ux-foundation.org, rppt@...ux.ibm.com, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, Huacai Chen <chenhuacai@...nel.org>,
WANG Xuerui <kernel@...0n.name>, loongarch@...ts.linux.dev
Subject: Re: [RFC PATCH v3 2/3] mm: Add PUD level pagetable account
On Thu, Jun 30, 2022 at 07:11:15PM +0800, Baolin Wang wrote:
> +++ b/arch/loongarch/include/asm/pgalloc.h
> @@ -89,10 +89,15 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
> static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
> {
> pud_t *pud;
> + struct page *page;
>
> - pud = (pud_t *) __get_free_pages(GFP_KERNEL, PUD_ORDER);
> - if (pud)
> - pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table);
> + page = alloc_pages(GFP_KERNEL, PUD_ORDER);
Argh. I just got rid of PMD_ORDER from PA-RISC. Now Loongstupid has
reintroduced it, and worse introduced PUD_ORDER. See commit
7bf82eb3873f.
Powered by blists - more mailing lists