linux-kernel - Re: [PATCH v3] 9p fid refcount: add a 9p_fid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220703084808.1d6a9989@rorschach.local.home>
Date:   Sun, 3 Jul 2022 08:48:08 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Dominique Martinet <asmadeus@...ewreck.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Christian Schoenebeck <linux_oss@...debyte.com>,
        v9fs-developer@...ts.sourceforge.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] 9p fid refcount: add a 9p_fid_ref tracepoint

On Sat,  2 Jul 2022 19:29:14 +0900
Dominique Martinet <asmadeus@...ewreck.org> wrote:

> This adds a tracepoint event for 9p fid lifecycle tracing: when a fid
> is created, its reference count increased/decreased, and freed.
> The new 9p_fid_ref tracepoint should help anyone wishing to debug any
> fid problem such as missing clunk (destroy) or use-after-free.
> 
> Link: https://lkml.kernel.org/r/20220612085330.1451496-6-asmadeus@codewreck.org
> Signed-off-by: Dominique Martinet <asmadeus@...ewreck.org>
> ---
> 
> Just resending this single patch of the series as it's the only one
> without a review tag.
> 
> Steven, is it ok to carry it in my tree as is or do I need blessings
> from you or Ingo?

The addition of trace events do belong to the maintainers of where the
trace events go.

> (it depends on the previous patch so I'd carry it in my tree anyway,
> but would be more comfortable with a reviewed-by tag)

Yes, I prefer people Cc me on trace events just so that I can catch
mistakes or find better ways to accomplish what is trying to be done.

Especially for something that does changes like this patch, which are
not just the trivial TRACE_EVENT() trace_*() procedure. Thanks for
Cc'ing me.

> 
> 
> v2 -> v3:
>  - added EXPORT_TRACEPOINT_SYMBOL(9p_fid_ref) to have this work when
>    built as module
> 
> v1 -> v2:
>  - added rationale to commit message
>  - adjusted to use DECLARE_TRACEPOINT + tracepoint_enable() in header
> 
>  include/net/9p/client.h   | 13 +++++++++++
>  include/trace/events/9p.h | 48 +++++++++++++++++++++++++++++++++++++++
>  net/9p/client.c           | 20 +++++++++++++++-
>  3 files changed, 80 insertions(+), 1 deletion(-)
> 

The rest looks fine.

For the tracing point of view:

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve