linux-kernel - Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220703101344.59710a42@rorschach.local.home>
Date:   Sun, 3 Jul 2022 10:13:44 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Aaron Tomlin <atomlin@...hat.com>
Cc:     Luis Chamberlain <mcgrof@...nel.org>, christophe.leroy@...roup.eu,
        cl@...ux.com, mbenes@...e.cz, akpm@...ux-foundation.org,
        jeyu@...nel.org, linux-kernel@...r.kernel.org,
        linux-modules@...r.kernel.org, void@...ifault.com,
        atomlin@...mlin.com, allen.lkml@...il.com, joe@...ches.com,
        msuchanek@...e.de, oleksandr@...alenko.name,
        jason.wessel@...driver.com, pmladek@...e.com,
        daniel.thompson@...aro.org, hch@...radead.org,
        Chuck Lever III <chuck.lever@...cle.com>
Subject: Re: [PATCH v11 09/14] module: Move kallsyms support into a separate
 file

On Sun, 3 Jul 2022 14:57:08 +0100
Aaron Tomlin <atomlin@...hat.com> wrote:

> Hi Steve,
> 
> I completely agree and noted.
> 
> > You even stated "no functional change" which was a lie. Converting
> > strlcpy() to strscpy() *is* a functional change!  
> 
> Understood.

Sorry about being harsh. It's something that was engrained in me when
doing kernel development, and something I found useful for all software
development.

Honestly, the hardest thing about kernel development is the review
process. The easier we can make reviewing, the better the code will be.

Cheers,

-- Steve