linux-kernel - Re: [PATCH] tracing/ipv4/ipv6: Give size to name field in fib*_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f25dd4a-7394-cf97-4fc8-c43f0c449fc7@gmail.com>
Date:   Sun, 3 Jul 2022 13:03:20 -0600
From:   David Ahern <dsahern@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] tracing/ipv4/ipv6: Give size to name field in
 fib*_lookup_table event

On 7/3/22 8:23 AM, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@...dmis.org>
> 
> The fib_lookup_table and fib6_lookup_table events declare name as a
> dynamic_array, but also give it a fixed size, which defeats the purpose of
> the dynamic array, especially since the dynamic array also includes meta
> data in the event to specify its size.
> 
> Considering that the intent was to only reserve the size needed for the
> name and not a fixed size, convert the size part of the __dynamic_array()
> field to contain the necessary code to determine the size needed to save
> the name.
> 
> Alternatively, if the intent was to use a fixed size, then it should be
> converted into __array() of type char, which will remove the meta data in
> the event that stores the size.

I would prefer this option over duplicating the all of the checks to
save 14B.