linux-kernel - Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YsMTHTcOWX4Q3W7f@smile.fi.intel.com>
Date:   Mon, 4 Jul 2022 19:19:41 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        sound-open-firmware@...a-project.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver
 data retrieval

On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote:
> On 03/07/2022 17:35, Andy Shevchenko wrote:

...

> +	return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
>  }

> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data

I prefer not to cast inside the function parameters when it's not about POD.

-- 
With Best Regards,
Andy Shevchenko