linux-kernel - Re: [PATCH] csky: Use the bitmap API to allocate bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJF2gTTjywpxzRBFwM79JugqRWP1ABdDUbA3PLqy9k9RAd9ujA@mail.gmail.com>
Date:   Tue, 5 Jul 2022 07:47:47 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, linux-csky@...r.kernel.org
Subject: Re: [PATCH] csky: Use the bitmap API to allocate bitmaps

Thx and looks good to me.

On Tue, Jul 5, 2022 at 3:08 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.
>
> While at it, turn a bitmap_clear() into an equivalent bitmap_zero(). It is
> also less verbose.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  arch/csky/mm/asid.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/csky/mm/asid.c b/arch/csky/mm/asid.c
> index b2e914745c1d..7fb6c417bbac 100644
> --- a/arch/csky/mm/asid.c
> +++ b/arch/csky/mm/asid.c
> @@ -27,7 +27,7 @@ static void flush_context(struct asid_info *info)
>         u64 asid;
>
>         /* Update the list of reserved ASIDs and the ASID bitmap. */
> -       bitmap_clear(info->map, 0, NUM_CTXT_ASIDS(info));
> +       bitmap_zero(info->map, NUM_CTXT_ASIDS(info));
>
>         for_each_possible_cpu(i) {
>                 asid = atomic64_xchg_relaxed(&active_asid(info, i), 0);
> @@ -178,8 +178,7 @@ int asid_allocator_init(struct asid_info *info,
>          */
>         WARN_ON(NUM_CTXT_ASIDS(info) - 1 <= num_possible_cpus());
>         atomic64_set(&info->generation, ASID_FIRST_VERSION(info));
> -       info->map = kcalloc(BITS_TO_LONGS(NUM_CTXT_ASIDS(info)),
> -                           sizeof(*info->map), GFP_KERNEL);
> +       info->map = bitmap_zalloc(NUM_CTXT_ASIDS(info), GFP_KERNEL);
>         if (!info->map)
>                 return -ENOMEM;
>
> --
> 2.34.1
>


-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/