linux-kernel - Re: [PATCH] net: hns: Fix spelling mistake in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e13e0c4-dc70-4228-609c-288f8db6ddc3@infradead.org>
Date:   Sun, 3 Jul 2022 23:07:32 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Zhang Jiaming <jiaming@...china.com>, yisen.zhuang@...wei.com,
        salil.mehta@...wei.com, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        liqiong@...china.com, renyu@...china.com
Subject: Re: [PATCH] net: hns: Fix spelling mistake in comments

Hi--

On 7/3/22 18:42, Zhang Jiaming wrote:
> There is a typo(waitting) in comments.
> FIx it.
> 
> Signed-off-by: Zhang Jiaming <jiaming@...china.com>
> ---
>  drivers/net/ethernet/hisilicon/hns_mdio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
> index 07fdab58001d..c239c407360f 100644
> --- a/drivers/net/ethernet/hisilicon/hns_mdio.c
> +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c
> @@ -174,7 +174,7 @@ static int hns_mdio_wait_ready(struct mii_bus *bus)
>  	u32 cmd_reg_value;
>  	int i;
>  
> -	/* waitting for MDIO_COMMAND_REG 's mdio_start==0 */
> +	/* waiting for MDIO_COMMAND_REG 's mdio_start==0 */

Also: no space here:   MDIO_COMMAND_REG's

>  	/* after that can do read or write*/
>  	for (i = 0; i < MDIO_TIMEOUT; i++) {
>  		cmd_reg_value = MDIO_GET_REG_BIT(mdio_dev,
> @@ -319,7 +319,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum)
>  				   MDIO_C45_READ, phy_id, devad);
>  	}
>  
> -	/* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/
> +	/* Step 5: waiting for MDIO_COMMAND_REG 's mdio_start==0,*/

Same here.

>  	/* check for read or write opt is finished */
>  	ret = hns_mdio_wait_ready(bus);
>  	if (ret) {

-- 
~Randy