linux-kernel - Re: [PATCH 1/2] ARM: at91: add sam_linux_is_in_normal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe771973-e9aa-d397-1849-41617cc2d226@microchip.com>
Date:   Mon, 4 Jul 2022 06:19:17 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <clement.leger@...tlin.com>, <linux@...linux.org.uk>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 1/2] ARM: at91: add sam_linux_is_in_normal_world()
 function

Hi, Clement,

On 06.06.2022 17:57, Clément Léger wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Add sam_linux_is_in_normal_world() which allows to know if Linux is
> running in the normal world or not. This function is used by code
> which needs to differentiate the world in which Linux is running.
> 
> Signed-off-by: Clément Léger <clement.leger@...tlin.com>
> ---
>  arch/arm/mach-at91/sam_secure.c | 6 ++++++
>  arch/arm/mach-at91/sam_secure.h | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/arch/arm/mach-at91/sam_secure.c b/arch/arm/mach-at91/sam_secure.c
> index 2a01f7a7d13f..1ec8c8b9d119 100644
> --- a/arch/arm/mach-at91/sam_secure.c
> +++ b/arch/arm/mach-at91/sam_secure.c
> @@ -27,6 +27,12 @@ struct arm_smccc_res sam_smccc_call(u32 fn, u32 arg0, u32 arg1)
>         return res;
>  }
> 
> +bool sam_linux_is_in_normal_world(void)
> +{
> +       /* If optee has been detected, then we are running in normal world */

In case optee hasn't been detected don't we run also in normal world?
What I want to say is that maybe you can change the function name to
something like sam_linux_is_optee_available().

Thank you,
Claudiu Beznea

> +       return optee_available;
> +}
> +
>  void __init sam_secure_init(void)
>  {
>         struct device_node *np;
> diff --git a/arch/arm/mach-at91/sam_secure.h b/arch/arm/mach-at91/sam_secure.h
> index 1e7d8b20ba1e..6d8c01f9c5f0 100644
> --- a/arch/arm/mach-at91/sam_secure.h
> +++ b/arch/arm/mach-at91/sam_secure.h
> @@ -14,5 +14,6 @@
> 
>  void __init sam_secure_init(void);
>  struct arm_smccc_res sam_smccc_call(u32 fn, u32 arg0, u32 arg1);
> +bool sam_linux_is_in_normal_world(void);
> 
>  #endif /* SAM_SECURE_H */
> --
> 2.36.1
>