lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <99526f90-f4c9-2785-f159-beace854b4a0@arm.com>
Date:   Mon, 4 Jul 2022 08:38:09 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Daniel Lezcano <daniel.lezcano@...exp.org>,
        daniel.lezcano@...aro.org
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        khilman@...libre.com, abailon@...libre.com,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, rafael@...nel.org
Subject: Re: [PATCH v3 01/12] thermal/core: Remove duplicate information when
 an error occurs



On 7/3/22 19:30, Daniel Lezcano wrote:
> The pr_err already tells it is an error, it is pointless to add the
> 'Error:' string in the messages. Remove them.
> 
> Cc: Alexandre Bailon <abailon@...libre.com>
> Cc: Kevin Hilman <khilman@...libre.com>
> Cc; Eduardo Valentin <eduval@...zon.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...exp.org>
> ---
>   drivers/thermal/thermal_core.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index cdc0552e8c42..e22e7d939c54 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1198,23 +1198,23 @@ thermal_zone_device_register(const char *type, int trips, int mask,
>   	struct thermal_governor *governor;
>   
>   	if (!type || strlen(type) == 0) {
> -		pr_err("Error: No thermal zone type defined\n");
> +		pr_err("No thermal zone type defined\n");
>   		return ERR_PTR(-EINVAL);
>   	}
>   
>   	if (type && strlen(type) >= THERMAL_NAME_LENGTH) {
> -		pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n",
> +		pr_err("Thermal zone name (%s) too long, should be under %d chars\n",
>   		       type, THERMAL_NAME_LENGTH);
>   		return ERR_PTR(-EINVAL);
>   	}
>   
>   	if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) {
> -		pr_err("Error: Incorrect number of thermal trips\n");
> +		pr_err("Incorrect number of thermal trips\n");
>   		return ERR_PTR(-EINVAL);
>   	}
>   
>   	if (!ops) {
> -		pr_err("Error: Thermal zone device ops not defined\n");
> +		pr_err("Thermal zone device ops not defined\n");
>   		return ERR_PTR(-EINVAL);
>   	}
>   

Reviewed-by: Lukasz Luba <lukasz.luba@....com>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ