[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YsKhAFkd0HCZVVvH@lunn.ch>
Date: Mon, 4 Jul 2022 10:12:48 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc: Wei Fang <wei.fang@....com>, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, aisheng.dong@....com,
devicetree@...r.kernel.org, peng.fan@....com, ping.bai@....com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-imx@....com, kernel@...gutronix.de, sudeep.holla@....com,
festevam@...il.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support
> > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>,
> > + <&pcc4 IMX8ULP_CLK_ENET>,
> > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>,
> > + <&clock_ext_rmii>;
> > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
>
> I think the default should be the other way round, assume MAC to provide reference
> clock and allow override on board-level if PHY does it instead.
I would make it the same as all the other instances of FEC in the
IMX7, IMX6, IMX5, IMX4, Vybrid etc
Andrew
Powered by blists - more mailing lists