linux-kernel - Re: [PATCH] ia64: old_rr4 added under CONFIG_HUGETLB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Jul 2022 06:26:57 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     linux-ia64@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] ia64: old_rr4 added under CONFIG_HUGETLB_PAGE

On Sun, Jun 26, 2022 at 7:51 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> From: "Souptick Joarder (HPE)" <jrdr.linux@...il.com>
>
> kernel test robot throws below warning ->
>
> arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
>    arch/ia64/include/asm/mmu_context.h:127:48: warning: variable
> 'old_rr4' set but not used [-Wunused-but-set-variable]
>      127 |         unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
>
> Added it under CONFIG_HUGETLB_PAGE

Any comments on this patch ?

>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@...il.com>
> ---
>  arch/ia64/include/asm/mmu_context.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/ia64/include/asm/mmu_context.h b/arch/ia64/include/asm/mmu_context.h
> index 87a0d5bc11ef..06257e355d00 100644
> --- a/arch/ia64/include/asm/mmu_context.h
> +++ b/arch/ia64/include/asm/mmu_context.h
> @@ -124,9 +124,12 @@ reload_context (nv_mm_context_t context)
>  {
>         unsigned long rid;
>         unsigned long rid_incr = 0;
> -       unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
> +       unsigned long rr0, rr1, rr2, rr3, rr4;
>
> +#ifdef CONFIG_HUGETLB_PAGE
> +       unsigned long old_rr4;
>         old_rr4 = ia64_get_rr(RGN_BASE(RGN_HPAGE));
> +#endif
>         rid = context << 3;     /* make space for encoding the region number */
>         rid_incr = 1 << 8;
>
> --
> 2.25.1
>