linux-kernel - [PATCH] ima/evm: Fix potential memory leak in ima_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220704005932.2217025-1-niejianglei2021@163.com>
Date:   Mon,  4 Jul 2022 08:59:32 +0800
From:   Jianglei Nie <niejianglei2021@....com>
To:     zohar@...ux.ibm.com, dmitry.kasatkin@...il.com, jmorris@...ei.org,
        serge@...lyn.com
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jianglei Nie <niejianglei2021@....com>
Subject: [PATCH] ima/evm: Fix potential memory leak in ima_init_crypto()

ima_init_crypto() allocates a memory chunk for "ima_algo_array" with
kcalloc(). When some errors occur, the function jumps to "out_array"
and releases the "ima_algo_array[i].tfm". But "ima_algo_array" is
not released, which will lead to a memory leak.

We can release the ima_algo_array with kfree() when some errors occur
to fix the memory leak.

Signed-off-by: Jianglei Nie <niejianglei2021@....com>
---
 security/integrity/ima/ima_crypto.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/integrity/ima/ima_crypto.c b/security/integrity/ima/ima_crypto.c
index a7206cc1d7d1..64499056648a 100644
--- a/security/integrity/ima/ima_crypto.c
+++ b/security/integrity/ima/ima_crypto.c
@@ -205,6 +205,7 @@ int __init ima_init_crypto(void)
 
 		crypto_free_shash(ima_algo_array[i].tfm);
 	}
+	kfree(ima_algo_array);
 out:
 	crypto_free_shash(ima_shash_tfm);
 	return rc;
-- 
2.25.1