linux-kernel - Re: [PATCH v2] bus: hisi_lpc: fix missing platform_device_put() in hisi_lpc_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2667eb2f-c341-88e6-3e49-116053f91ee4@huawei.com>
Date:   Mon, 4 Jul 2022 10:40:15 +0100
From:   John Garry <john.garry@...wei.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        <linux-kernel@...r.kernel.org>, <rafael@...nel.org>
CC:     <andriy.shevchenko@...ux.intel.com>, <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] bus: hisi_lpc: fix missing platform_device_put() in
 hisi_lpc_acpi_probe()

On 04/07/2022 10:34, Yang Yingliang wrote:
> In error case in hisi_lpc_acpi_probe() after calling platform_device_alloc(),
> if platform_device_add() is not called successfully, hisi_lpc_acpi_remove()
> can't release the failed 'pdev' including its resource and data, so they will
> be leaked, call platform_device_put() to put the refcount, then they will be
> freed in platform_device_release().
> I'v constructed this error case and tested this patch on D05 board.

/s/I'v/I've/

> 
> Fixes: 99c0228d6ff1 ("HISI LPC: Re-Add ACPI child enumeration support")
> Reported-by: Hulk Robot<hulkci@...wei.com>
> Signed-off-by: Yang Yingliang<yangyingliang@...wei.com>

Reviewed-by: John Garry <john.garry@...wei.com>