linux-kernel - Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YsLJ7+HiqaBTwCLg@kroah.com>
Date:   Mon, 4 Jul 2022 13:07:27 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     szuni chen <szunichen@...il.com>
Cc:     ChiaEn Wu <peterwu.pub@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        "Krogerus, Heikki" <heikki.krogerus@...ux.intel.com>,
        Helge Deller <deller@....de>, chiaen_wu@...htek.com,
        alice_chen@...htek.com, ChiYuan Huang <cy_huang@...htek.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        USB <linux-usb@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        "open list:FRAMEBUFFER LAYER" <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370
 tcpci driver

On Mon, Jul 04, 2022 at 05:31:29PM +0800, szuni chen wrote:
> Greg KH <gregkh@...uxfoundation.org> 於 2022年7月4日 週一 下午3:32寫道：
> >
> > On Mon, Jul 04, 2022 at 01:38:56PM +0800, ChiaEn Wu wrote:
> > > From: ChiYuan Huang <cy_huang@...htek.com>
> > >
> > > Add chip level mt6370 tcpci driver.
> >
> > What does this mean?  Please provide more information about the hardware
> > being supported here so we know how to review this.
> 
> Dear Greg,
> 
> MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery charger,
> a USB Type-C & Power Delivery (PD) controller, dual flash LED current sources,
> a RGB LED driver, a backlight WLED driver, a display bias driver and a
> general LDO for portable devices.
> 
> This driver is used for the Type-C & Power Delivery controller in
> MediaTek MT6370 IC.
> 
> If we change the commit message to
> 
> "Add MediaTek MT6370 tcpci driver.
> MediaTek MT6370 is a multi-functional IC that includes USB Type-C.
> It works with Type-C Port Controller Manager to provide USB PD and USB
> Type-C functionalities."
> 
> does this meet your requirements?

What would you want to see if you were reading a changelog text for an
unfamiliar hardware device?  More text is always better!

thanks,

greg k-h