linux-kernel - Re: [PATCH] habanalabs: Use the bitmap API to allocate bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf10SQ6E85Vyyx4P=pq-CwYrH874vPp73J5EdObFZ4=YNwA@mail.gmail.com>
Date:   Mon, 4 Jul 2022 14:48:01 +0300
From:   Oded Gabbay <ogabbay@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] habanalabs: Use the bitmap API to allocate bitmaps

On Sun, Jul 3, 2022 at 11:36 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/misc/habanalabs/common/asid.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/common/asid.c b/drivers/misc/habanalabs/common/asid.c
> index ede04c032b6e..c9c2619cc43d 100644
> --- a/drivers/misc/habanalabs/common/asid.c
> +++ b/drivers/misc/habanalabs/common/asid.c
> @@ -11,8 +11,7 @@
>
>  int hl_asid_init(struct hl_device *hdev)
>  {
> -       hdev->asid_bitmap = kcalloc(BITS_TO_LONGS(hdev->asic_prop.max_asid),
> -                                       sizeof(*hdev->asid_bitmap), GFP_KERNEL);
> +       hdev->asid_bitmap = bitmap_zalloc(hdev->asic_prop.max_asid, GFP_KERNEL);
>         if (!hdev->asid_bitmap)
>                 return -ENOMEM;
>
> @@ -27,7 +26,7 @@ int hl_asid_init(struct hl_device *hdev)
>  void hl_asid_fini(struct hl_device *hdev)
>  {
>         mutex_destroy(&hdev->asid_mutex);
> -       kfree(hdev->asid_bitmap);
> +       bitmap_free(hdev->asid_bitmap);
>  }
>
>  unsigned long hl_asid_alloc(struct hl_device *hdev)
> --
> 2.34.1
>

Thanks!
This patch is
Reviewed-by: Oded Gabbay <ogabbay@...nel.org>
Applied to -next.
Oded