linux-kernel - Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Jul 2022 15:04:13 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     Martin Kaiser <lists@...ser.cx>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

On Fri, Jul 01, 2022 at 10:58:58PM +0300, Pavel Skripkin wrote:
> Hi Martin,
> 
> Martin Kaiser <lists@...ser.cx> says:
> > Thus wrote Yang Li (yang.lee@...ux.alibaba.com):
> > 
> > > Eliminate the following coccicheck warning:
> > > ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon
> > 
> > > Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> > > ---
> > >  drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > > diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > index b5f6d41464db..5b0f66573d94 100644
> > > --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> > > @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
> > >  		break;
> > >  	default:
> > >  		return false;
> > > -	};
> > > +	}
> > 
> > >  	do {
> > >  		pwrcfgcmd = pwrseqcmd[aryidx];
> > > -- 
> > > 2.20.1.7.g153144c
> > 
> > Thanks for spotting this.
> > 
> > Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
> 
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> No need to backport code-style warning, so Fixes: is not needed here.
> 

The Fixes tag doesn't have to do with backporting...

I do think it should only be used for bugs.  So I would not have used it
here.  But other people do encourage it for style issues so I have given
up fighting about that.

regards,
dan carpenter