[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0c5ac567-a279-cb95-ac04-729040436091@linaro.org>
Date: Mon, 4 Jul 2022 14:46:38 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Leo Yan <leo.yan@...aro.org>, Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Georgi Djakov <djakov@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Subject: Re: [PATCH v3 1/5] dt-bindings: interconnect: Update property for
icc-rpm path tag
On 04/07/2022 11:30, Leo Yan wrote:
> To support path tag in icc-rpm driver, the "#interconnect-cells"
> property is updated as enumerate values: 1 or 2. Setting to 1 means
> it is compatible with old DT binding that interconnect path only
> contains node id; if set to 2 for "#interconnect-cells" property, then
> the second specifier is used as a tag (e.g. vote for which buckets).
>
> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---
> .../devicetree/bindings/interconnect/qcom,rpm.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
> index 8a676fef8c1d..cdfe419e7339 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
> @@ -45,7 +45,12 @@ properties:
> - qcom,sdm660-snoc
>
> '#interconnect-cells':
> - const: 1
> + description: |
> + Number of interconnect specifier.
Isn't this sentence obvious (common for every bindings)? Just skip it.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Value: <1> is one cell in a
> + interconnect specifier for the interconnect node id, <2> requires
> + the interconnect node id and an extra path tag.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 1, 2 ]
>
> clocks:
> minItems: 2
Best regards,
Krzysztof
Powered by blists - more mailing lists