linux-kernel - Re: [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cd658cd-3b8c-89d1-651d-ce81794fb68c@linaro.org>
Date:   Mon, 4 Jul 2022 17:22:21 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     Rajendra Nayak <quic_rjendra@...cinc.com>,
        Thara Gopinath <thara.gopinath@...il.com>
Subject: Re: [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring
 driver

On 04/07/2022 17:20, Randy Dunlap wrote:
> Hi,
> 
> On 7/4/22 05:17, Krzysztof Kozlowski wrote:
>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>> index e718b8735444..2c8091535bf7 100644
>> --- a/drivers/soc/qcom/Kconfig
>> +++ b/drivers/soc/qcom/Kconfig
>> @@ -228,4 +228,19 @@ config QCOM_APR
>>  	  application processor and QDSP6. APR is
>>  	  used by audio driver to configure QDSP6
>>  	  ASM, ADM and AFE modules.
>> +
>> +config QCOM_ICC_BWMON
>> +	tristate "QCOM Interconnect Bandwidth Monitor driver"
>> +	depends on ARCH_QCOM || COMPILE_TEST
>> +	select PM_OPP
>> +	help
>> +	  Sets up driver monitoring bandwidth on various interconnects and
> 
> 	  Sets up driver bandwidth monitoring
> 
> would be better, I think.

It's a driver which monitors bandwidth, so your version sounds a bit
like monitoring of driver's bandwidth.

Maybe should be:
    Sets up driver which monitors bandwidth...
?
> 
>> +	  based on that voting for interconnect bandwidth, adjusting their
>> +	  speed to current demand.
>> +	  Current implementation brings support for BWMON v4, used for example
>> +	  on SDM845 to measure bandwidth between CPU (gladiator_noc) and Last
>> +	  Level Cache (memnoc).  Usage of this BWMON allows to remove some of
>> +	  the fixed bandwidth votes from cpufreq (CPU nodes) thus achieve high
>> +	  memory throughput even with lower CPU frequencies.
> 


Best regards,
Krzysztof