[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXv+5FsTNKgWG75eSKt4ngnhmSekWNT+oS1ke+P4tazHDdnzQ@mail.gmail.com>
Date: Tue, 5 Jul 2022 12:03:08 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: Nícolas F. R. A. Prado
<nfraprado@...labora.com>
Cc: Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>, kernel@...labora.com,
Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
Fabien Parent <fparent@...libre.com>,
Hsin-Yi Wang <hsinyi@...omium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Luca Weiss <luca@...tu.xyz>, Maxim Kutnij <gtk3@...ox.ru>,
Rob Herring <robh+dt@...nel.org>,
Sam Shih <sam.shih@...iatek.com>,
Sean Wang <sean.wang@...iatek.com>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v4 00/19] Introduce support for MediaTek MT8192 Google Chromebooks
On Fri, Jul 1, 2022 at 11:01 PM Nícolas F. R. A. Prado
<nfraprado@...labora.com> wrote:
>
> On Fri, Jul 01, 2022 at 08:44:53PM +0800, Chen-Yu Tsai wrote:
> > On Thu, Jun 30, 2022 at 12:00 AM Nícolas F. R. A. Prado
> > <nfraprado@...labora.com> wrote:
> > >
> > >
> > > This series introduces Devicetrees for the MT8192-based Asurada platform
> > > as well as Asurada Spherion and Asurada Hayato boards.
> > >
> > > Support for the boards is added to the extent that is currently enabled
> > > in the mt8192.dtsi, and using only properties already merged in the
> > > dt-bindings, as to not add any dependencies to this series.
> > >
> > > This series was peer-reviewed internally before submission.
> > >
> > > Series tested on next-20220629.
> >
> > Just FYI I also got the internal display to work after some fixes to
> > the dtsi [1] and copying the stuff over from the ChromeOS kernel tree.
> >
> > It might be harder to enable the external display, given that we don't
> > have a good way of describing the weird design of using the DP bridge
> > also as a mux. See [2] for ongoing discussion.
>
> Hi ChenYu,
>
> I actually have both the internal and external display working on my local
> branch [1], but the commits there aren't final, and I'm also following the
> Type-C switch discussion to update my commits whenever the binding is settled
> on.
I see. I think the internal display part is more or less final. It should
be worth including it, as it is a fairly visible indication that things
are working.
ChenYu
> I noticed the lack of the mandatory display aliases in the mt8192 series but
> somehow missed mentioning that in the review, so thanks for adding that.
>
> Thanks,
> Nícolas
>
> [1] https://gitlab.collabora.com/nfraprado/linux/-/commits/mt8192-asurada
>
> >
> > ChenYu
> >
> > [1] https://lore.kernel.org/linux-mediatek/CAGXv+5F_Gi_=vV1NSk0AGRVYCa3Q8+gBaE+nv3OJ1AKe2voOwg@mail.gmail.com/
> > [2] https://lore.kernel.org/dri-devel/20220622173605.1168416-1-pmalani@chromium.org/
> >
> > > v3: https://lore.kernel.org/all/20220512205602.158273-1-nfraprado@collabora.com/
> > > v2: https://lore.kernel.org/all/20220505194550.3094656-1-nfraprado@collabora.com/
> > > v1: https://lore.kernel.org/all/20220316151327.564214-1-nfraprado@collabora.com/
> > >
> > > Changes in v4:
> > > - Added patches 17-19 enabling MMC, SCP and SPI NOR flash
> > > - Switched mediatek,drive-strength-adv for drive-strength-microamp
> > > - Switched mediatek,pull-up-adv for bias-pull-up
> > > - Updated Vgpu minimum voltage to appropriate value
> > >
> > > Changes in v3:
> > > - Renamed regulator nodes to be generic
> > > - Fixed keyboard layout for Hayato
> > >
> > > Changes in v2:
> > > - Added patches 1-2 for Mediatek board dt-bindings
> > > - Added patches 13-16 enabling hardware for Asurada that has since been
> > > enabled on mt8192.dtsi
> > >
> > > Nícolas F. R. A. Prado (19):
> > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion
> > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato
> > > arm64: dts: mediatek: Introduce MT8192-based Asurada board family
> > > arm64: dts: mediatek: asurada: Document GPIO names
> > > arm64: dts: mediatek: asurada: Add system-wide power supplies
> > > arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses
> > > arm64: dts: mediatek: asurada: Add ChromeOS EC
> > > arm64: dts: mediatek: asurada: Add keyboard mapping for the top row
> > > arm64: dts: mediatek: asurada: Add Cr50 TPM
> > > arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad
> > > arm64: dts: mediatek: asurada: Add I2C touchscreen
> > > arm64: dts: mediatek: spherion: Add keyboard backlight
> > > arm64: dts: mediatek: asurada: Enable XHCI
> > > arm64: dts: mediatek: asurada: Enable PCIe and add WiFi
> > > arm64: dts: mediatek: asurada: Add MT6359 PMIC
> > > arm64: dts: mediatek: asurada: Add SPMI regulators
> > > arm64: dts: mediatek: asurada: Enable MMC
> > > arm64: dts: mediatek: asurada: Enable SCP
> > > arm64: dts: mediatek: asurada: Add SPI NOR flash memory
> > >
> > > .../devicetree/bindings/arm/mediatek.yaml | 13 +
> > > arch/arm64/boot/dts/mediatek/Makefile | 2 +
> > > .../dts/mediatek/mt8192-asurada-hayato-r1.dts | 47 +
> > > .../mediatek/mt8192-asurada-spherion-r0.dts | 62 ++
> > > .../boot/dts/mediatek/mt8192-asurada.dtsi | 959 ++++++++++++++++++
> > > 5 files changed, 1083 insertions(+)
> > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts
> > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts
> > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
> > >
> > > --
> > > 2.36.1
> > >
Powered by blists - more mailing lists