linux-kernel - Re: [PATCH v4 04/14] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jul 2022 12:50:47 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <vkoul@...nel.org>, <conor@...nel.org>
CC:     <airlied@...ux.ie>, <daniel@...ll.ch>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <thierry.reding@...il.com>,
        <sam@...nborg.org>, <Eugeniy.Paltsev@...opsys.com>,
        <lgirdwood@...il.com>, <broonie@...nel.org>,
        <fancer.lancer@...il.com>, <daniel.lezcano@...aro.org>,
        <palmer@...belt.com>, <palmer@...osinc.com>,
        <paul.walmsley@...ive.com>, <aou@...s.berkeley.edu>,
        <Conor.Dooley@...rochip.com>, <masahiroy@...nel.org>,
        <damien.lemoal@...nsource.wdc.com>, <geert@...ux-m68k.org>,
        <niklas.cassel@....com>, <dillon.minfei@...il.com>,
        <joabreu@...opsys.com>, <dri-devel@...ts.freedesktop.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dmaengine@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v4 04/14] dt-bindings: dma: dw-axi-dmac: extend the number
 of interrupts

On 05/07/2022 13:46, Vinod Koul wrote:
> On 01-07-22, 20:22, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@...rochip.com>
>>
>> The Canaan k210 apparently has a Sysnopsys Designware AXI DMA
>> controller, but according to the documentation & devicetree it has 6
>> interrupts rather than the standard one. Support the 6 interrupt
>> configuration by unconditionally extending the binding to a maximum of
>> 8 per-channel interrupts thereby matching the number of possible
>> channels.
>>
>> Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51
>> Reviewed-by: Serge Semin <fancer.lancer@...il.com>
>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>> ---
>>   .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml          | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> index 4324a94b26b2..98c2ab18d04f 100644
>> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> @@ -34,7 +34,12 @@ properties:
>>         - const: axidma_apb_regs
>>   
>>     interrupts:
>> -    maxItems: 1
>> +    description: |
> 
> rob asked you to drop this in last patch, pls fix that and send with his
> ack

Yeah, I was a bit gung-ho & sent before v4 with other fixes prior
to his review of v3. I didn't intentionally ignore him :)

I'll resend later tonight.

Thanks,
Conor.

> 
>> +      If the IP-core synthesis parameter DMAX_INTR_IO_TYPE is set to 1, this
>> +      will be per-channel interrupts. Otherwise, this is a single combined IRQ
>> +      for all channels.
>> +    minItems: 1
>> +    maxItems: 8
>>   
>>     clocks:
>>       items:
>> -- 
>> 2.37.0
>