linux-kernel - Re: [PATCH 09/14] arm64: dts: qcom: sc8280xp: drop UFS PHY clock-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8e44194-4a9f-be6f-a170-e59757476837@linaro.org>
Date:   Tue, 5 Jul 2022 16:06:19 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Johan Hovold <johan+linaro@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/14] arm64: dts: qcom: sc8280xp: drop UFS PHY
 clock-cells

On 05/07/2022 14:40, Johan Hovold wrote:
> The QMP UFS PHY provides more than one symbol clock and would need an
> index to differentiate the clocks, but none of this is described by the
> binding currently.
> 
> Drop the incorrect '#clock-cells' property for now.

Could you please take a glance whether 
https://lore.kernel.org/linux-arm-msm/20220620153956.1723269-2-dmitry.baryshkov@linaro.org/ 
makes a sense to the sc8280xp platform?

> 
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 345a19a6e874..ce4df4e814fe 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1447,7 +1447,6 @@ ufs_mem_phy_lanes: phy@...7400 {
>   				      <0 0x01d87800 0 0x108>,
>   				      <0 0x01d87a00 0 0x1e0>;
>   				#phy-cells = <0>;
> -				#clock-cells = <0>;
>   			};
>   		};
>   
> @@ -1517,7 +1516,6 @@ ufs_card_phy_lanes: phy@...7400 {
>   				      <0 0x01da7800 0 0x108>,
>   				      <0 0x01da7a00 0 0x1e0>;
>   				#phy-cells = <0>;
> -				#clock-cells = <0>;
>   			};
>   		};
>   


-- 
With best wishes
Dmitry