linux-kernel - RE: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property nxp,fspi-dll-slvdly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jul 2022 13:19:56 +0000
From:   Han Xu <han.xu@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bough Chen <haibo.chen@....com>,
        "ashish.kumar@....com" <ashish.kumar@....com>,
        "yogeshgaur.83@...il.com" <yogeshgaur.83@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "singh.kuldeep87k@...il.com" <singh.kuldeep87k@...il.com>,
        "tudor.ambarus@...rochip.com" <tudor.ambarus@...rochip.com>,
        "p.yadav@...com" <p.yadav@...com>,
        "michael@...le.cc" <michael@...le.cc>,
        "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
        "richard@....at" <richard@....at>,
        "vigneshr@...com" <vigneshr@...com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
CC:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "zhengxunli@...c.com.tw" <zhengxunli@...c.com.tw>
Subject: RE: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property
 nxp,fspi-dll-slvdly



>-----Original Message-----
>From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>Sent: Tuesday, July 5, 2022 5:37 AM
>To: Bough Chen <haibo.chen@....com>; ashish.kumar@....com;
>yogeshgaur.83@...il.com; broonie@...nel.org; robh+dt@...nel.org;
>krzysztof.kozlowski+dt@...aro.org; Han Xu <han.xu@....com>;
>singh.kuldeep87k@...il.com; tudor.ambarus@...rochip.com; p.yadav@...com;
>michael@...le.cc; miquel.raynal@...tlin.com; richard@....at; vigneshr@...com;
>shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de
>Cc: linux-spi@...r.kernel.org; linux-kernel@...r.kernel.org;
>devicetree@...r.kernel.org; linux-mtd@...ts.infradead.org; festevam@...il.com;
>dl-linux-imx <linux-imx@....com>; linux-arm-kernel@...ts.infradead.org;
>zhengxunli@...c.com.tw
>Subject: Re: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property
>nxp,fspi-dll-slvdly
>
>On 05/07/2022 12:28, Bough Chen wrote:
>>> -----Original Message-----
>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> Sent: 2022年7月5日 17:48
>>> To: Bough Chen <haibo.chen@....com>; ashish.kumar@....com;
>>> yogeshgaur.83@...il.com; broonie@...nel.org; robh+dt@...nel.org;
>>> krzysztof.kozlowski+dt@...aro.org; Han Xu <han.xu@....com>;
>>> singh.kuldeep87k@...il.com; tudor.ambarus@...rochip.com;
>>> p.yadav@...com; michael@...le.cc; miquel.raynal@...tlin.com;
>>> richard@....at; vigneshr@...com; shawnguo@...nel.org;
>>> s.hauer@...gutronix.de; kernel@...gutronix.de
>>> Cc: linux-spi@...r.kernel.org; linux-kernel@...r.kernel.org;
>>> devicetree@...r.kernel.org; linux-mtd@...ts.infradead.org;
>>> festevam@...il.com; dl-linux-imx <linux-imx@....com>;
>>> linux-arm-kernel@...ts.infradead.org; zhengxunli@...c.com.tw
>>> Subject: Re: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new
>>> property nxp,fspi-dll-slvdly
>>>
>>> On 05/07/2022 11:11, haibo.chen@....com wrote:
>>>> From: Haibo Chen <haibo.chen@....com>
>>>>
>>>> Add one optional property nxp,fspi-dll-slvdly
>>>>
>>>> Signed-off-by: Haibo Chen <haibo.chen@....com>
>>>> ---
>>>>  Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml
>>> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml
>>>> index 1b552c298277..6bd61565686a 100644
>>>> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml
>>>> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml
>>>> @@ -45,6 +45,12 @@ properties:
>>>>        - const: fspi_en
>>>>        - const: fspi
>>>>
>>>> +  nxp,fspi-dll-slvdly:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    description: |
>>>> +      Specify the DLL slave line delay value.
>>>
>>> What are the units?
>>
>> Do you mean here need to give more detail explain about this properity?
>>
>> How about change like this?
>>    Specify the DLL slave line delay value. The delay target for slave delay line is:
>((nxp,fspi-dll-slvdly+1) * 1/32 * clock cycle of reference clock (serial root clock).
>
>This would be good.
>
>> The range of this value is 0~16.
>
>This needs to go to schema instead as "maximum: 16".
>
>But still the question is - what are the units used in this "delay"? ms? us?

HI Krzysztof,

According to the formula, the range should be 0~15, 16 should do nothing or no delay.

The unit should be clock phase. In other words, the delay can be in range of 1/32~1/2 clock cycle.


>
>Best regards,
>Krzysztof