linux-kernel - Re: [PATCH][next] fs/ntfs3: remove duplicated assignment to variable r

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ece0504-43ae-84f2-cfcf-ad12520bc195@paragon-software.com>
Date:   Tue, 5 Jul 2022 16:31:57 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Colin Ian King <colin.i.king@...il.com>, <ntfs3@...ts.linux.dev>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] fs/ntfs3: remove duplicated assignment to variable
 r

On 7/4/22 21:53, Colin Ian King wrote:
> The assignment to variable r is duplicated, the second assignment
> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   fs/ntfs3/run.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ntfs3/run.c b/fs/ntfs3/run.c
> index 7609d45a2d72..aba8ab1b9fcb 100644
> --- a/fs/ntfs3/run.c
> +++ b/fs/ntfs3/run.c
> @@ -563,7 +563,6 @@ bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len)
>   	e = run->runs + run->count;
>   	r = run->runs + index;
>   
> -	r = run->runs + index;
>   	if (vcn > r->vcn)
>   		r += 1;
>   

Thanks for patch, applied!