lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Jul 2022 16:27:28 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Xin Ji <xji@...logixsemi.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org> Cc: bliang@...logixsemi.com, qwen@...logixsemi.com, jli@...logixsemi.com, Rob Herring <robh@...nel.org>, linux-usb@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v13 2/3] dt-bindings: usb: Add analogix anx7411 PD binding On 05/07/2022 07:36, Xin Ji wrote: > Add analogix PD chip anx7411 device binding > > Reviewed-by: Rob Herring <robh@...nel.org> > Signed-off-by: Xin Ji <xji@...logixsemi.com> > > --- > v12 -> v13 : > 1. Drop the quotes for "$id" and "$schema" > 2. Remove "allOf" label > 3. Change node name from "i2c1" to "i2c" > 4. Change node name from "typec" to "usb-typec" > --- > .../bindings/usb/analogix,anx7411.yaml | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > new file mode 100644 > index 000000000000..57429864d499 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/analogix,anx7411.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analogix ANX7411 Type-C controller bindings > + > +maintainers: > + - Xin Ji <xji@...logixsemi.com> > + > +properties: > + compatible: > + enum: > + - analogix,anx7411 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + connector: > + type: object > + $ref: ../connector/usb-connector.yaml > + description: > + Properties for usb c connector. > + > + properties: > + compatible: > + const: usb-c-connector > + > + power-role: true > + > + data-role: true > + > + try-power-role: true > + > + required: > + - compatible > + > +required: > + - compatible > + - reg > + - connector > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb-typec: anx7411@2C { 1. node name is still not correct. 2. lowercase hex, so @2c. > + compatible = "analogix,anx7411"; > + reg = <0x2C>; lowercase hex > + interrupts = <8 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&gpio0>; > + > + typec_con: connector { > + compatible = "usb-c-connector"; > + power-role = "dual"; > + data-role = "dual"; > + try-power-role = "source"; The DT schema requires ports property and just "port" is not accepted. > + > + port { > + typec_con_ep: endpoint { > + remote-endpoint = <&usbotg_hs_ep>; > + }; > + }; > + }; > + }; > + }; > +... Best regards, Krzysztof
Powered by blists - more mailing lists