linux-kernel - Re: [PATCH v1 3/4] bus: hisi_lpc: Correct error code for timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93547c1e-76c6-c5af-ca9b-27053a9e26a3@intel.com>
Date:   Tue, 5 Jul 2022 16:39:40 +0200
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        <linux-kernel@...r.kernel.org>
CC:     <john.garry@...wei.com>
Subject: Re: [PATCH v1 3/4] bus: hisi_lpc: Correct error code for timeout

On 7/5/2022 1:43 PM, Andy Shevchenko wrote:
> The usual error code is -ETIMEDOUT, the currently used -ETIME is specific
> for timers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>


> ---
>   drivers/bus/hisi_lpc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 03d4d96ff794..a6513a571d7b 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -85,7 +85,7 @@ static int wait_lpc_idle(void __iomem *mbase, unsigned int waitcnt)
>   		ndelay(LPC_NSEC_PERWAIT);
>   	} while (--waitcnt);
>   
> -	return -ETIME;
> +	return -ETIMEDOUT;
>   }
>   
>   /*