[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f85d13df-b3b9-5cde-6f4c-a68507cedee9@huawei.com>
Date: Tue, 5 Jul 2022 15:51:56 +0100
From: John Garry <john.garry@...wei.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 4/4] bus: hisi_lpc: Don't guard ACPI IDs with
ACPI_PTR()
On 05/07/2022 12:43, Andy Shevchenko wrote:
> The OF is not guarded neither ACPI needs.
This doesn't read well.
> The IDs do not depend
> to the configuration. Hence drop ACPI_PTR() from the code and
> move ID table closer to its user.
Do you need to explicitly include mod_devicetable.h, which has the
definition of acpi_device_id?
I saw a similar change for another driver and it was claimed that
including mod_devicetable.h was required.
Thanks,
John
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/bus/hisi_lpc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index a6513a571d7b..74f4448bff9d 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -589,11 +589,6 @@ static int hisi_lpc_acpi_probe(struct device *hostdev)
>
> return ret;
> }
> -
> -static const struct acpi_device_id hisi_lpc_acpi_match[] = {
> - {"HISI0191"},
> - {}
> -};
> #else
> static int hisi_lpc_acpi_probe(struct device *dev)
> {
> @@ -688,11 +683,16 @@ static const struct of_device_id hisi_lpc_of_match[] = {
> {}
> };
>
> +static const struct acpi_device_id hisi_lpc_acpi_match[] = {
> + {"HISI0191"},
> + {}
> +};
> +
> static struct platform_driver hisi_lpc_driver = {
> .driver = {
> .name = DRV_NAME,
> .of_match_table = hisi_lpc_of_match,
> - .acpi_match_table = ACPI_PTR(hisi_lpc_acpi_match),
> + .acpi_match_table = hisi_lpc_acpi_match,
> },
> .probe = hisi_lpc_probe,
> .remove = hisi_lpc_remove,
Powered by blists - more mailing lists