linux-kernel - RE: [EXT] [PATCH v3] PCI: endpoint: pci-epf-vntb: reduce several globals to statics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PAXPR04MB918658D6AC3A0A341E4260FC88819@PAXPR04MB9186.eurprd04.prod.outlook.com>
Date:   Tue, 5 Jul 2022 15:14:33 +0000
From:   Frank Li <frank.li@....com>
To:     Tom Rix <trix@...hat.com>, "kishon@...com" <kishon@...com>,
        "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
        "kw@...ux.com" <kw@...ux.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "jdmason@...zu.us" <jdmason@...zu.us>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH v3] PCI: endpoint: pci-epf-vntb: reduce several
 globals to statics



> -----Original Message-----
> From: Tom Rix <trix@...hat.com>
> Sent: Monday, July 4, 2022 8:26 AM
> To: kishon@...com; lpieralisi@...nel.org; kw@...ux.com;
> bhelgaas@...gle.com; jdmason@...zu.us; Frank Li <frank.li@....com>
> Cc: linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org; Tom Rix
> <trix@...hat.com>
> Subject: [EXT] [PATCH v3] PCI: endpoint: pci-epf-vntb: reduce several globals
> to statics
> 
> Caution: EXT Email
> 
> sparse reports
> drivers/pci/endpoint/functions/pci-epf-vntb.c:956:10: warning: symbol
> 'pci_space' was not declared. Should it be static?
> drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning: symbol
> 'pci_read' was not declared. Should it be static?
> drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning: symbol
> 'pci_write' was not declared. Should it be static?
> drivers/pci/endpoint/functions/pci-epf-vntb.c:989:16: warning: symbol
> 'vpci_ops' was not declared. Should it be static?
> 
> These functions and variables are only used in pci-epf-vntb.c, so their storage
> class specifiers should be static.
> 
> Fixes: ff32fac00d97 ("NTB: EPF: support NTB transfer between PCI RC and EP
> connection")
> Signed-off-by: Tom Rix <trix@...hat.com>

Acked-by: Frank Li <Frank.Li@....com>

> ---
> v2,3 : Change commit prefix
> 
> ---
>  drivers/pci/endpoint/functions/pci-epf-vntb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> index ebf7e243eefa..6f0775b1fec3 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -953,7 +953,7 @@ static struct config_group *epf_ntb_add_cfs(struct
> pci_epf *epf,
> 
>  #define VPCI_BUS_NUM 0x10
> 
> -uint32_t pci_space[] = {
> +static uint32_t pci_space[] = {
>         (VNTB_VID | (VNTB_PID << 16)),  //DeviceID, Vendor ID
>         0,              // status, Command
>         0xffffffff,     // Class code, subclass, prog if, revision id
> @@ -972,7 +972,7 @@ uint32_t pci_space[] = {
>         0,              //Max Lat, Min Gnt, interrupt pin, interrupt line
>  };
> 
> -int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32
> *val)
> +static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int
> size, u32 *val)
>  {
>         if (devfn == 0) {
>                 memcpy(val, ((uint8_t *)pci_space) + where, size);
> @@ -981,12 +981,12 @@ int pci_read(struct pci_bus *bus, unsigned int
> devfn, int where, int size, u32 *
>         return -1;
>  }
> 
> -int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32
> val)
> +static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int
> size, u32 val)
>  {
>         return 0;
>  }
> 
> -struct pci_ops vpci_ops = {
> +static struct pci_ops vpci_ops = {
>         .read = pci_read,
>         .write = pci_write,
>  };
> --
> 2.27.0