linux-kernel - Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver data retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfcbeMt=OUamfyoheqxX1gcCoov+976ewPUerfH=wSxRg@mail.gmail.com>
Date:   Tue, 5 Jul 2022 17:25:39 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        sound-open-firmware@...a-project.org,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v1 1/1] ASoC: SOF: Intel: bdw: remove duplicating driver
 data retrieval

On Tue, Jul 5, 2022 at 3:19 PM Péter Ujfalusi
<peter.ujfalusi@...ux.intel.com> wrote:
> On 04/07/2022 19:19, Andy Shevchenko wrote:
> > On Mon, Jul 04, 2022 at 10:31:48AM +0300, Péter Ujfalusi wrote:
> >> On 03/07/2022 17:35, Andy Shevchenko wrote:

...

> >> +    return sof_acpi_probe(pdev, (const struct sof_dev_desc *)id->driver_data);
> >>  }
> >
> >> We don't use the desc in sof_broadwell_probe(), so we can just pass the id->driver_data
> >
> > I prefer not to cast inside the function parameters when it's not about POD.
>
> Fair enough.
>
> How about assigning desc before it is used?

As answered in the other email, I'm fine to modify the change accordingly.

-- 
With Best Regards,
Andy Shevchenko