linux-kernel - Re: [PATCH v3 1/1] ASoC: Intel: catpt: remove duplicating driver data retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6b52455-87d6-2125-55ce-bdc7aa522085@intel.com>
Date:   Tue, 5 Jul 2022 18:14:54 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
CC:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v3 1/1] ASoC: Intel: catpt: remove duplicating driver data
 retrieval

On 2022-07-05 5:58 PM, Andy Shevchenko wrote:
> device_get_match_data() in ACPI case calls similar to acpi_match_device().
> Hence there is no need to duplicate the call. Just assign what is in
> the id->driver_data.


Thanks for the patch! Change looks good:

Acked-by: Cezary Rojewski <cezary.rojewski@...el.com>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v3: moved spec assignment closer to its user (Péter, Czarek)
>   sound/soc/intel/catpt/device.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/sound/soc/intel/catpt/device.c b/sound/soc/intel/catpt/device.c
> index 85a34e37316d..d48a71d2cf1e 100644
> --- a/sound/soc/intel/catpt/device.c
> +++ b/sound/soc/intel/catpt/device.c
> @@ -254,14 +254,11 @@ static int catpt_acpi_probe(struct platform_device *pdev)
>   		return -ENODEV;
>   	}
>   
> -	spec = device_get_match_data(dev);
> -	if (!spec)
> -		return -ENODEV;
> -
>   	cdev = devm_kzalloc(dev, sizeof(*cdev), GFP_KERNEL);
>   	if (!cdev)
>   		return -ENOMEM;
>   
> +	spec = (const struct catpt_spec *)id->driver_data;
>   	catpt_dev_init(cdev, dev, spec);
>   
>   	/* map DSP bar address */