linux-kernel - Re: [RFC PATCH] netfs: do not get the folio reference twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2dcc7854-643c-0c77-b0b6-9443b9ee1dcd@redhat.com>
Date:   Tue, 5 Jul 2022 14:11:20 +0800
From:   Xiubo Li <xiubli@...hat.com>
To:     dhowells@...hat.com
Cc:     linux-kernel@...r.kernel.org, willy@...radead.org,
        keescook@...omium.org, linux-fsdevel@...r.kernel.org,
        linux-cachefs@...hat.com
Subject: Re: [RFC PATCH] netfs: do not get the folio reference twice


On 7/5/22 10:22 AM, xiubli@...hat.com wrote:
> From: Xiubo Li <xiubli@...hat.com>
>
> And also the comment said it will drop the folio references but
> the code was increasing it.
>
> Signed-off-by: Xiubo Li <xiubli@...hat.com>
> ---
>   fs/netfs/buffered_read.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c
> index 5b93e22397fe..a44a5b3b8d4c 100644
> --- a/fs/netfs/buffered_read.c
> +++ b/fs/netfs/buffered_read.c
> @@ -396,9 +396,6 @@ int netfs_write_begin(struct netfs_inode *ctx,
>   	 */
>   	ractl._nr_pages = folio_nr_pages(folio);
>   	netfs_rreq_expand(rreq, &ractl);
> -
> -	/* We hold the folio locks, so we can drop the references */
> -	folio_get(folio);
>   	while (readahead_folio(&ractl))
>   		;
>   

Will drop this patch, the above fix it incorrect.

Thanks!