linux-kernel - Re: [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220705202831.GA2566864-robh@kernel.org>
Date:   Tue, 5 Jul 2022 14:28:31 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jernej Škrabec <jernej.skrabec@...il.com>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Samuel Holland <samuel@...lland.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Ripard <mripard@...nel.org>, devicetree@...r.kernel.org,
        dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max
 typo

On Sat, Jul 02, 2022 at 09:34:41PM +0200, Jernej Škrabec wrote:
> Dne sobota, 02. julij 2022 ob 05:19:02 CEST je Samuel Holland napisal(a):
> > The conditional block for variants with a second clock should have set
> > minItems, not maxItems, which was already 2. Since clock-names requires
> > two items, this typo should not have caused any problems.
> > 
> > Fixes: edd14218bd66 ("dt-bindings: dmaengine: Convert Allwinner A31 and A64
> > DMA to a schema") Signed-off-by: Samuel Holland <samuel@...lland.org>
> > ---
> > 
> >  .../devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml       | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml index
> > ff0a5c58d78c..e712444abff1 100644
> > --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > @@ -67,7 +67,7 @@ if:
> >  then:
> >    properties:
> >      clocks:
> > -      maxItems: 2
> > +      minItems: 2
> 
> These specific variants have exactly 2 clocks. Having both limits seems right.

You do. The main section has 2 for the max.

Rob